Fix exception on missing video fields#245
Merged
ikalchev merged 2 commits intoikalchev:devfrom May 6, 2020
Merged
Conversation
Make logging consistent
Codecov Report
@@ Coverage Diff @@
## dev #245 +/- ##
==========================================
- Coverage 63.13% 62.96% -0.17%
==========================================
Files 16 16
Lines 1725 1731 +6
Branches 180 185 +5
==========================================
+ Hits 1089 1090 +1
Misses 589 589
- Partials 47 52 +5
|
Contributor
Author
|
Also Home Assistant now has HomeKit camera support in the upcoming 0.110 🍾 |
Owner
|
I suppose a release with the fix is needed. Anything else I should wait for before doing it? |
Contributor
Author
Nothing else in the queue so a release would be appreciated. Thank you! |
Contributor
Author
bdraco
added a commit
to bdraco/home-assistant
that referenced
this pull request
May 12, 2020
Fix race condition that causes pairing and unpairing failures. ikalchev/HAP-python#246 Fix loop on dropped connections that causes temporary stalls and connection loss. ikalchev/HAP-python#249 Fix exception on missing video fields. ikalchev/HAP-python#245
20 tasks
bdraco
added a commit
to home-assistant/core
that referenced
this pull request
May 12, 2020
Fix race condition that causes pairing and unpairing failures. ikalchev/HAP-python#246 Fix loop on dropped connections that causes temporary stalls and connection loss. ikalchev/HAP-python#249 Fix exception on missing video fields. ikalchev/HAP-python#245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes care of the
# TODO: Optionals, handle the case where they are missing. Sometimes streams would fail to start because a field would be missing inVIDEO_TYPES['ATTRIBUTES']. Everything is starting consistently now with this change.Logging was calling
logginginstead ofloggerlike the other modules. This meant the debug log didn't show up in Home Asssistant.